perf: utilize smartstring for string handling (#5149)

* perf: utilize smartstring for string handling

- Updated various modules to replace standard String with smartstring::alias::String for improved performance and memory efficiency.
- Adjusted string manipulations and conversions throughout the codebase to ensure compatibility with the new smartstring type.
- Enhanced readability and maintainability by using `.into()` for conversions where applicable.
- Ensured that all instances of string handling in configuration, logging, and network management leverage the benefits of smartstring.

* fix: replace wrap_err with stringify_err for better error handling in UWP tool invocation

* refactor: update import path for StringifyErr and adjust string handling in sysopt

* fix: correct import path for CmdResult in UWP module

* fix: update argument type for execute_sysproxy_command to use std::string::String

* fix: add missing CmdResult import in UWP platform module

* fix: improve string handling and error messaging across multiple files

* style: format code for improved readability and consistency across multiple files

* fix: remove unused file
This commit is contained in:
Tunglies
2025-10-22 16:25:44 +08:00
committed by GitHub
parent fe96a7030a
commit a05ea64bcd
50 changed files with 361 additions and 272 deletions

View File

@@ -6,6 +6,7 @@ use crate::utils::{
use anyhow::{Context, Result, bail};
use serde::{Deserialize, Serialize};
use serde_yaml_ng::Mapping;
use smartstring::alias::String;
use std::collections::HashSet;
use tokio::fs;
@@ -47,7 +48,7 @@ impl IProfiles {
if let Some(items) = profiles.items.as_mut() {
for item in items.iter_mut() {
if item.uid.is_none() {
item.uid = Some(help::get_uid("d"));
item.uid = Some(help::get_uid("d").into());
}
}
}
@@ -142,7 +143,7 @@ impl IProfiles {
let file = item.file.clone().ok_or_else(|| {
anyhow::anyhow!("file field is required when file_data is provided")
})?;
let path = dirs::app_profiles_dir()?.join(&file);
let path = dirs::app_profiles_dir()?.join(file.as_str());
fs::write(&path, file_data.as_bytes())
.await
@@ -240,13 +241,13 @@ impl IProfiles {
// move the field value after save
if let Some(file_data) = item.file_data.take() {
let file = each.file.take();
let file =
file.unwrap_or(item.file.take().unwrap_or(format!("{}.yaml", &uid)));
let file = file
.unwrap_or(item.file.take().unwrap_or(format!("{}.yaml", &uid).into()));
// the file must exists
each.file = Some(file.clone());
let path = dirs::app_profiles_dir()?.join(&file);
let path = dirs::app_profiles_dir()?.join(file.as_str());
fs::write(&path, file_data.as_bytes())
.await
@@ -291,7 +292,7 @@ impl IProfiles {
&& let Some(file) = items.remove(index).file
{
let _ = dirs::app_profiles_dir()?
.join(file)
.join(file.as_str())
.remove_if_exists()
.await;
}
@@ -306,7 +307,7 @@ impl IProfiles {
&& let Some(file) = items.remove(index).file
{
let _ = dirs::app_profiles_dir()?
.join(file)
.join(file.as_str())
.remove_if_exists()
.await;
}
@@ -321,7 +322,7 @@ impl IProfiles {
&& let Some(file) = items.remove(index).file
{
let _ = dirs::app_profiles_dir()?
.join(file)
.join(file.as_str())
.remove_if_exists()
.await;
}
@@ -336,7 +337,7 @@ impl IProfiles {
&& let Some(file) = items.remove(index).file
{
let _ = dirs::app_profiles_dir()?
.join(file)
.join(file.as_str())
.remove_if_exists()
.await;
}
@@ -351,7 +352,7 @@ impl IProfiles {
&& let Some(file) = items.remove(index).file
{
let _ = dirs::app_profiles_dir()?
.join(file)
.join(file.as_str())
.remove_if_exists()
.await;
}
@@ -366,7 +367,7 @@ impl IProfiles {
&& let Some(file) = items.remove(index).file
{
let _ = dirs::app_profiles_dir()?
.join(file)
.join(file.as_str())
.remove_if_exists()
.await;
}
@@ -392,7 +393,7 @@ impl IProfiles {
(Some(current), Some(items)) => {
if let Some(item) = items.iter().find(|e| e.uid.as_ref() == Some(current)) {
let file_path = match item.file.as_ref() {
Some(file) => dirs::app_profiles_dir()?.join(file),
Some(file) => dirs::app_profiles_dir()?.join(file.as_str()),
None => bail!("failed to get the file field"),
};
return help::read_mapping(&file_path).await;
@@ -544,7 +545,7 @@ impl IProfiles {
log::info!(target: "app", "已清理冗余文件: {file_name}");
}
Err(e) => {
failed_deletions.push(format!("{file_name}: {e}"));
failed_deletions.push(format!("{file_name}: {e}").into());
log::warn!(target: "app", "清理文件失败: {file_name} - {e}");
}
}